Skip to content

Slight refactoring, extend README, add test-lambda to CI builds #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

Slight refactoring, extend README, add test-lambda to CI builds #4

merged 3 commits into from
Oct 2, 2025

Conversation

@whummer
Copy link
Collaborator

@whummer whummer commented Oct 2, 2025 •
edited
Loading

  • slight refactoring of the Web app
  • add make web-ui target to spin up the Web UI locally (via serve)
  • extend README
  • run make format to format the codebase
  • add test-lambda as a build step to the CI builds

@whummer whummer force-pushed the refactor-web-app branch 3 times, most recently from 404a4b9 to 743d32c Compare October 2, 2025 11:37
@whummer
Copy link
Collaborator Author

whummer commented Oct 2, 2025 •
edited
Loading

@flyingsilverfin Looks like one of the tests is still failing in the CI build - any idea what could be wrong? 👀

        # List group members
        response = requests.get(f"{self.base_url}/groups/testgroup/members")
        assert response.status_code == 200
        members = response.json()
>       assert len(members) == 1
E       assert 0 == 1
E        +  where 0 = len([])
tests/test_lambda.py:188: AssertionError
=========================== short test summary info ============================
FAILED tests/test_lambda.py::TestLambdaAPI::test_add_users_to_group - assert 0 == 1
 +  where 0 = len([])

(If we don't find the root cause or it's a flaky test, then we could probably also just mark the test as xfail for now..)

@whummer
Copy link
Collaborator Author

whummer commented Oct 2, 2025 •
edited
Loading

Builds are green, after rebasing onto latest master branch - fyi @flyingsilverfin going to merge these changes in now. 👍 (thanks for fixing the setup!)

@whummer whummer merged commit 8cd7527 into master Oct 2, 2025
1 check passed
@whummer whummer deleted the refactor-web-app branch October 2, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flyingsilverfin flyingsilverfin Awaiting requested review from flyingsilverfin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whummer